On Mon, Mar 22, 2010 at 2:53 PM, Brian Gerkey wrote: >> I had a quick look, and this looks great. There is quite a bit of >> variation from person to person. We try not to get too uptight about >> details of coding style. > > True enough, though we do have style guides for C++ and Python: > > http://www.ros.org/wiki/CppStyleGuide > http://www.ros.org/wiki/PyStyleGuide I had actually read these, but forgot some of the details. Looks like the most obvious violation was naming the files CameraInfoManager.{cpp,h}, after the class name. I guess I should rename them camera_info_manager.{cpp,h}. That difference is quite visible. -- joq