Alright, lets try this again. Modified patch and tar file: git clone http://robotics.ccny.cuny.edu/git/ccny-ros-pkg/ccny_vision.git cd ccny_vision wget http://www.cs.utexas.edu/~piyushk/artoolkit-patch-natty-v2.txt git apply artoolkit-patch-natty-v2.txt rosmake ccny_vision --rosdep-install The patched tar that will be downloaded is http://www.cs.utexas.edu/~piyushk/ARToolKit-r311-Natty.tar.gz I have verified that artoolkit compiles on natty (w/o linux/videodev.h) and on lucid (w/ linux/videodev.h), so I have a good belief that this will be backwards compatible. Since ARToolkit does not use autoconf, I have patched patch_v4l to test for the include file and generate a config accordingly. The svn diff for artoolkit and the patch are attached to this email in case you wish to analyze them. You will have to make the appropriate changes once the patched ARToolKit is uploaded to https://code.ros.org/svn/release/download/thirdpart Hope this works this time around! Let me know if you face any problems. Piyush On Sat, Oct 8, 2011 at 5:59 PM, Piyush wrote: > This is correct - the patch was only for Natty. For some weird reason > I assumed that the debs could be built externally without pushing this > change to the repository. It was a bad idea in the first place. > > I will see if I can work on this later tonight - the patch is still > relatively easy based on what Bill suggests, and will require > modifying ARToolKit's custom configuration script to provide the > LIBV4L1 flag as necessary. > > Piyush > > On Sat, Oct 8, 2011 at 1:14 PM, Bill Morris wrote: >> Looking at the SED code >> $ roscd artoolkit >> $ sed -i 's,#include ,#include ,g' ./build/artoolkit/include/AR/sys/videoLinuxV4L.h >> $ sed -i 's,#include ,#include ,g' ./build/artoolkit/lib/SRC/VideoLinuxV4L/video.c >> >> It is clear that this patch will break previous version. >> >> You need something like ifdefs >> >> #ifdef LIBV4L1 >>  #include >> #else >>  #include >> #endif >> >> >> I built the previous patched artoolkit. >> You need to be added to the thirdparty group on code.ros.org >> https://code.ros.org/svn/release/download/thirdparty >> >> >> On Fri, 2011-10-07 at 17:47 -0400, Carlos J. wrote: >>> Piyush, >>> >>> Thanks for patching ARToolKit, However we have a concern: will this >>> modifications you've made to the v4l header affect other Ubuntu >>> distributions prior to Natty? In other words, before we make the patch >>> official, we must ensure that the patch will not affect other users >>> who run older Ubuntu distros. >>> >>> If that's the case, we will ask Ken from WG to upload the patched >>> ARToolKit to the download server at code.ros.org >>> >>> Carlos >>> >>> On Tue, Oct 4, 2011 at 1:26 PM, Piyush Khandelwal wrote: >>> > Hi, >>> > >>> > Currently ccny_vision has no packages for natty as it does not build >>> > without a patch. See: http://robotics.ccny.cuny.edu/trac/ticket/55 >>> > Instructions for manually patching are available here: >>> > http://www.ros.org/wiki/artoolkit >>> > >>> > I have a patch available at >>> > http://www.cs.utexas.edu/~piyushk/artoolkit-patch-natty.txt which >>> > automates the procedure above. i.e I can run this on any of my >>> > machines using the following commands: >>> > >>> > git clone http://robotics.ccny.cuny.edu/git/ccny-ros-pkg/ccny_vision.git >>> > cd ccny_vision >>> > wget http://www.cs.utexas.edu/~piyushk/artoolkit-patch-natty.txt >>> > git apply artoolkit-patch-natty.txt >>> > rosmake ccny_vision --rosdep-install >>> > >>> > Note: The tar downloaded will be >>> > http://www.cs.utexas.edu/~piyushk/ARToolKit-Natty.tar.gz. This has >>> > been patched. >>> > >>> > Is anybody from WG or CCNY interested in a more permanent fix to the >>> > problem, i.e. releasing packages for easier use. I am unfamiliar with >>> > the build process for releasing debs, so I am not sure how much work >>> > this entails. >>> > >>> > Thanks! >>> > Piyush >>> > _______________________________________________ >>> > ros-users mailing list >>> > ros-users@code.ros.org >>> > https://code.ros.org/mailman/listinfo/ros-users >>> > >>> _______________________________________________ >>> ros-users mailing list >>> ros-users@code.ros.org >>> https://code.ros.org/mailman/listinfo/ros-users >> >> -- >> Bill Morris >> I Heart Engineering >> http://www.iheartengineering.com >> <3 >> >> _______________________________________________ >> ros-users mailing list >> ros-users@code.ros.org >> https://code.ros.org/mailman/listinfo/ros-users >> >