On Fri, Jul 12, 2013 at 3:30 PM, Piyush wrote: > On Fri, Jul 12, 2013 at 5:22 PM, Jack O'Quin wrote: > >> >> On Fri, Jul 12, 2013 at 4:45 PM, Piyush wrote: >> >>> Hi folks, >>> >>> I just realized that one of my packages built despite missing upstream >>> dependencies. v0.1.0 did not depend on these missing deps, and they were >>> introduced in v0.1.1. The upstream deps include navigation, which AFAIK has >>> not seen a successful build. >>> >>> >>> http://jenkins.willowghttp://jenkins.willowgarage.com:8080/view/HbinP32/job/ros-hydr and o-segbot-navigation_binarydeb_precise_i386/arage.com:8080/view/HbinP32/job/ros-hydro-segbot-navigation_binarydeb_precise_i386/ >>> >>> Is this something to worry about? >>> >> >> Probably. >> > I think this is a jenkins bug. I'm going to file it upstream. > >> Since "navigation" was a rosbuild stack, now a metapackage, only other >> metapackages are allowed to depend on it. Since the devel version of >> segbot_navigation is a regular catkin package, that probably ought to >> generate an error. >> >> I that dependency needed at that level? >> > > I was not aware of this, and missed it during catkinization. The package > only has a real launch dependency on move_base, eband_local_planner and > navfn. I will change this with the next release. > Jack is right on this account. Packages should never depend on metapackages. Run depends do not have coverage on enforcement for the toolchain. > > >> >> I suppose eband_local_planner must declare all the navigation packages >> that it actually uses. >> > > It looks like I did fix the dependencies for eband_local_planner > correctly, and segbot_navigation has a dependency on eband that may have > gotten bypassed. > > >> -- >> joq >> > > > _______________________________________________ > Ros-release mailing list > Ros-release@code.ros.org > https://code.ros.org/mailman/listinfo/ros-release > >