On Wed, Apr 20, 2011 at 1:21 PM, Ken Conley <kwc@willowgarage.com> wrote:

Hi Ugo,

Thanks for the patch. We need to wait for the other tickets to land first, though, as they will change the underlying model being used. The main issue is that the Bzr implementation is using a SVN instead of a DVCS model. As the current create.py script is written on a DVCS model, it is better to leave as-is for now .

cheers,
Ken

On Wed, Apr 20, 2011 at 5:58 AM, Ugo Cupcic <ugo@shadowrobot.com> wrote:

Hi,

Please find attached a patch for the create.py bzr support. Once more it's probably not generic.

Here's what I did to be able to make a release:
1. there were some problems in the code, trying to access non existing config variables such as config.dev_branch, etc...

2. The bzr_client.checkout(from_url, config.dev_branch) didn't work for me: from_url and config.dev are the same in my case. Should it be bzr_client.checkout(from_url, config.release_tag)?
3. Anyway there's no need of checking out the code once more to tag the branch -> modified the command to tag directly, without using the tmp checkout.

I didn't use the create branch action.

Hope this helps.

Cheers,

Ugo

On Tue, Apr 19, 2011 at 8:58 PM, Ugo Cupcic <ugo@shadowrobot.com> wrote:

Dear Wim,

I also had to modify the create.py script to get it working. If you want I can send you a patch with some explanations on what I did tomorrow. My patch would probably not be completely generic because I'm not sure of what each variable of the config is meant to be.

Cheers,

Ugo

On Tue, Apr 19, 2011 at 6:06 PM, Wim Meeussen <meeussen@willowgarage.com> wrote:

Ugo,

Thanks for testing the bzr support again! I filed two tickets for the
remaining issues:

https://code.ros.org/trac/ros/ticket/3462
https://code.ros.org/trac/ros/ticket/3463

Wim

On Mon, Apr 18, 2011 at 9:02 AM, Ugo Cupcic <ugo@shadowrobot.com> wrote:

> Hi,
> I'm trying to release my shadow_robot stack using the create.py script.
> It didn't work as is and I had to modify it a bit:
> - config.repo_uri doesn't seem to exist
> There's no need of doing a new checkout of the code to tag it so I commented
> it out (as the checkout method was failing in tag_bzr).
> The tag command subprocess call was not working because config.dev_branch is
> undefined.
> I used this:
> bzr tag -d config.dev --force config.release_tag
> I'll be happy to send a patch, but I'm really not sure of what each item in
> the config is precisely supposed to be.
> Cheers,
> Ugo
> --
> Ugo Cupcic | Shadow Robot Company | ugo@shadowrobot.com
> Software Engineer | 251 Liverpool Road |
> need a Hand? | London N1 1LX | +44 20 7700 2487
> http://www.shadowrobot.com/hand/ @shadowrobot
>
>

> _______________________________________________
> ros-developers mailing list
> ros-developers@code.ros.org
> https://code.ros.org/mailman/listinfo/ros-developers
>
>

--
--
Wim Meeussen
Willow Garage Inc.
<http://www.willowgarage.com)

_______________________________________________
ros-developers mailing list
ros-developers@code.ros.org
https://code.ros.org/mailman/listinfo/ros-developers

--
Ugo Cupcic | Shadow Robot Company | ugo@shadowrobot.com
Software Engineer | 251 Liverpool Road |
need a Hand? | London N1 1LX | +44 20 7700 2487
http://www.shadowrobot.com/hand/ @shadowrobot

--
Ugo Cupcic | Shadow Robot Company | ugo@shadowrobot.com
Software Engineer | 251 Liverpool Road |
need a Hand? | London N1 1LX | +44 20 7700 2487
http://www.shadowrobot.com/hand/ @shadowrobot

_______________________________________________
ros-developers mailing list
ros-developers@code.ros.org
https://code.ros.org/mailman/listinfo/ros-developers

_______________________________________________
ros-developers mailing list
ros-developers@code.ros.org
https://code.ros.org/mailman/listinfo/ros-developers