On, Feb 25, 2013 at 3:14 AM, Armin Hornung <span dir="ltr">&lt;<a href="mailto:HornungA@informatik.uni-freiburg.de" target="_blank">HornungA@informatik.uni-freiburg.de</a>&gt;</span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">


  
    
  
  <div bgcolor="#FFFFFF" text="#000000"><div class="im">
    <div>On 2013-02-20 21:25, William Woodall
      wrote:<br>
    </div>
    <blockquote type="cite">I have drafted a REP, tentatively REP-136, which is an
      Informational REP providing a recommendation for how to release
      third party packages into the ROS ecosystem. In this context a
      third party package is any software package which is used in the
      ROS ecosystem, but exists outside of the ROS ecosystem, and
      therefore is neither catkin based nor rosbuild based.
      <div>
        <br>
      </div>
      <div>You can find this draft REP here:</div>
      <div><br>
      </div>
      <div><a href="https://github.com/ros-infrastructure/rep/blob/release_third_party/rep-0136.rst" target="_blank">https://github.com/ros-infrastructure/rep/blob/release_third_party/rep-0136.rst</a></div>
    </blockquote>
    <br></div>
    +1<br>
    <br>
    After using the previous version in bloom/catkin this new REP has
    some great improvements for third-party (non-catkin) packages such
    as OctoMap, and the explanations clear up many things.<div class="im"><br>
    <br>
    <br>
    <blockquote type="cite">
      <div><br>
      </div>
      <div>And the pull request containing the drafting history is here:</div>
      <div><br>
      </div>
      <div><a href="https://github.com/ros-infrastructure/rep/pull/23" target="_blank">https://github.com/ros-infrastructure/rep/pull/23</a></div>
      <div><br>
      </div>
      <div>To summarize the recommendation, third party packages should:</div>
      <div>
        <ul>
          <li>Have a package.xml</li>
          <ul>
            <li>Which run_depend&#39;s on catkin</li>
            <li>Has a &lt;build_type&gt; tag in the &lt;export&gt;
              section</li>
          </ul>
          <li>Install the package.xml</li>
        </ul>
      </div>
    </blockquote>
    <br></div>
    This and the motivation / rationale in the REP sound like it&#39;s
    recommended to put the package.xml in the the upstream source repo,
    while the specification recommends to inject the templated version
    into the release-repo (putting package.xml into the upstream repo is
    only mentioned as alternative). This should probably be cleared up
    with a clear preference on one method. From the maintenance
    overhead, putting package.xml into the upstream source repo sounds
    like the best to me (if there is control of the upstream repo by the
    maintainer).<br></div></blockquote><div><br></div><div>Putting a package.xml and install rule in the upstream repository is the preferred method, but I realize that many people do not want this or cannot put this in their upstream repository, so bloom allows for injection of these two things into the release repository.</div>

<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000">
    <br>
    Or maybe it&#39;s just not clearly worded? The specification section
    mentions &quot;Inject a templated package.xml into the upstream using
    bloom&quot;. Here, &quot;upstream&quot; probably means the upstream branch in the
    ros-gbp release repo, whereas in other places it also refers to the
    upstream repository. This should be clearly differentiated, as the
    context may not always be clear to the uninitiated reader.<br>
    <br>
    Other than that I only found a small (but potentially confusing)
    typo. Pull request here:
    <a href="https://github.com/ros-infrastructure/rep/pull/28" target="_blank">https://github.com/ros-infrastructure/rep/pull/28</a><br>
    Is that how the process should work on GitHub?<br></div></blockquote><div><br></div><div>That&#39;s how it works, I have merged your pull request into the third party rep branch (which updated my pull request) Thanks!</div>

<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000">
    <br>
    Best,<span class="HOEnZb"><font color="#888888"><br>
    <pre cols="72">-- 
Armin Hornung
Humanoid Robots Lab, Albert-Ludwigs-Universität Freiburg
Contact: <a href="http://www.informatik.uni-freiburg.de/~hornunga" target="_blank">http://www.informatik.uni-freiburg.de/~hornunga</a></pre>
  </font></span></div>

</blockquote></div><br><br clear="all"><div><br></div>-- <br>William Woodall<div>Willow Garage - Software Engineer</div><div><a href="mailto:wwoodall@willowgarage.com" target="_blank">wwoodall@willowgarage.com</a></div>