I am not sure why you didn't get the correct diff.

Also I am not sure why you got the error when doing a second release.

I'm looking into both now.

While I was reviewing I found some things:

- You should remove this file: https://github.com/shadow-robot/sr-ronex/blob/hydro/CMakeLists.txt
- This is no longer used in catkin: https://github.com/shadow-robot/sr-ronex/blob/hydro/sr_ronex_utilities/package.xml#L38

I'll continue looking into it, I would recommend you delete the release repository and try bloom again to see if you can reproduce the error. You could also open a ticket against bloom when you find out how to reproduce it.

--


On Wed, Sep 25, 2013 at 9:35 AM, Toni Oliver Duran <toliver.shadow@gmail.com> wrote:
Hi, I added the <export><metapackage/> tag to the correct package.xml and tried to do a new release (0.9.3 this time).

But now bloom-release fails (yesterday it worked well when doing the first release).

The error is related to a git rm command in a package 'sr_ronex_hardware_interface' that has not changed (only the version no.)

 [git-bloom-patch rebase]: 'execute_command' failed to call 'git rm -rf *' which had a return code (128):
 [git-bloom-patch rebase]: ```
fatal: pathspec 'bin' did not match any files


The full output:


> bloom-release sr_ronex --track hydro --rosdistro hydro
==> Fetching 'sr_ronex' repository from 'https://github.com/shadow-robot/sr-ronex-release.git'
Cloning into '/tmp/tmptWhdKN'...
remote: Counting objects: 1033, done.
remote: Compressing objects: 100% (620/620), done.
remote: Total 1033 (delta 316), reused 1030 (delta 316)
Receiving objects: 100% (1033/1033), 257.01 KiB | 453 KiB/s, done.
Resolving deltas: 100% (316/316), done.
==> Testing for push permission on release repository
==> git remote -v
==> git push --dry-run
Everything up-to-date
==> Releasing 'sr_ronex' using release track 'hydro'
==> git-bloom-release hydro
Processing release track settings for 'hydro'
Checking upstream devel branch for package.xml(s)
Cloning into '/tmp/tmp9YVnPt/upstream'...
remote: Counting objects: 2871, done.
remote: Compressing objects: 100% (1271/1271), done.
remote: Total 2871 (delta 1515), reused 2835 (delta 1479)
Receiving objects: 100% (2871/2871), 1008.83 KiB | 548 KiB/s, done.
Resolving deltas: 100% (1515/1515), done.
Looking for packages in 'hydro' branch... found 10 packages.
Detected version '0.9.3' from package(s): ['sr_ronex_drivers', 'sr_ronex_hardware_interface', 'sr_ronex_utilities', 'sr_ronex_msgs', 'sr_ronex_transmissions', 'sr_ronex_launch', 'sr_ronex_controllers', 'sr_ronex_external_protocol', 'sr_ronex', 'sr_ronex_examples']

Executing release track 'hydro'
==> bloom-export-upstream /tmp/tmp9YVnPt/upstream git --tag 0.9.3 --display-uri https://github.com/shadow-robot/sr-ronex.git --name sr_ronex --output-dir /tmp/tmpF6M3TD
Checking out repository at 'https://github.com/shadow-robot/sr-ronex.git' to reference '0.9.3'.
Exporting to archive: '/tmp/tmpF6M3TD/sr_ronex-0.9.3.tar.gz'
md5: 5367700c6dc95279124b0e39b7d76728

==> git-bloom-import-upstream /tmp/tmpF6M3TD/sr_ronex-0.9.3.tar.gz  --release-version 0.9.3 --replace
The latest upstream tag in the release repository is 'upstream/0.9.2'.
Importing archive into upstream branch...
Creating tag: 'upstream/0.9.3'
I'm happy.  You should be too.

==> git-bloom-generate -y rosrelease hydro --source upstream -i 0
Releasing packages: ['sr_ronex_drivers', 'sr_ronex_hardware_interface', 'sr_ronex_utilities', 'sr_ronex_msgs', 'sr_ronex_transmissions', 'sr_ronex_launch', 'sr_ronex_controllers', 'sr_ronex_external_protocol', 'sr_ronex', 'sr_ronex_examples']
Releasing package 'sr_ronex_drivers' for 'hydro' to: 'release/hydro/sr_ronex_drivers'
Releasing package 'sr_ronex_hardware_interface' for 'hydro' to: 'release/hydro/sr_ronex_hardware_interface'
 [git-bloom-patch rebase]: 'execute_command' failed to call 'git rm -rf *' which had a return code (128):
 [git-bloom-patch rebase]: ```
fatal: pathspec 'bin' did not match any files

 [git-bloom-patch rebase]: ```
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.7/bloom/commands/git/generate.py", line 101, in try_execute
    retcode = func(*args, **kwargs)
  File "/usr/lib/pymodules/python2.7/bloom/logging.py", line 210, in decorated
    return f(*args, **kwds)
  File "/usr/lib/pymodules/python2.7/bloom/commands/git/patch/rebase_cmd.py", line 146, in rebase_patches
    non_git_rebase(config['parent'], directory=directory)
  File "/usr/lib/pymodules/python2.7/bloom/commands/git/patch/rebase_cmd.py", line 42, in non_git_rebase
    execute_command('git rm -rf *', cwd=directory)
  File "/usr/lib/pymodules/python2.7/bloom/util.py", line 388, in execute_command
    raise CalledProcessError(result, cmd)
CalledProcessError: Command 'git rm -rf *' returned non-zero exit status 128

Error calling git-bloom-patch rebase: Command 'git rm -rf *' returned non-zero exit status 128
git-bloom-patch rebase returned exit code (128)
<== Error running command '['/usr/bin/git-bloom-generate', '-y', 'rosrelease', 'hydro', '--source', 'upstream', '-i', '0']'
Release failed, exiting.



Best Regards,

Toni



2013/9/25 Toni Oliver Duran <toliver.shadow@gmail.com>
Yes, sorry. I copied the wrong url in the email by mistake, but I put the right one in the release.yaml.

Is it possible that not having the <export> <metapackage/> tag in the package.xml of the metapackage was the cause of the problem?


2013/9/25 Jack O'Quin <jack.oquin@gmail.com>

On Wed, Sep 25, 2013 at 6:12 AM, Toni Oliver Duran <toliver.shadow@gmail.com> wrote:
This is a first-time release of a repo containing multiple packages (one of them a metapackage).

bloom-release seems to be working well and finding the different packages, but when generating the pull request to hydro/release.yaml it does not create the list of packages automatically.

I get

sr_ronex:
    tags:
      release: release/hydro/{package}/{version}
    url: git@github.com:shadow-robot/sr-ronex-release.git
    version: 0.9.2-0

When I expect:

sr_ronex:
    packages:
        sr_ronex:
        sr_ronex_controllers:
        sr_ronex_drivers:
        sr_ronex_examples:
        sr_ronex_external_protocol:
        sr_ronex_hardware_interface:
        sr_ronex_launch:
        sr_ronex_msgs:
        sr_ronex_transmissions:
        sr_ronex_utilities:
    tags:
      release: release/hydro/{package}/{version}
    url: git@github.com:shadow-robot/sr-ronex-release.git
    version: 0.9.2-0

Is the normal behaviour of bloom-release that the user adds the list of packages manually? Or it means that I did something wrong?

Looking at the release repo, bloom clearly did find all your packages, and you have the latest version of bloom.

I think your release URL should be the https address, not the git login address. The build farm can't log in as you. 
--
 joq



_______________________________________________
ros-release mailing list
ros-release@lists.ros.org
http://lists.ros.org/mailman/listinfo/ros-release




--
William Woodall
ROS Development Team
william@osrfoundation.org
http://williamjwoodall.com/