Ben,<div><br></div><div>I'm not sure that there's a recommended way to handle multiple goal types as this is something that we haven't done with great regularity, but I can try to give insight on the options and their trade-offs so that you can make the decision that's best for you. </div>
<div><br></div><div>Option 1 - Having extra fields in the .action file: We've used this approach for the grasping pipeline that we've built here at Willow and it seems to work pretty well. A clear disadvantage is that you have an .action file that contains more information than it strictly needs to and you need to check somehow which interface the user wants rather than having a separate type. Some might argue that this is also not as clean as providing two interfaces on separate ROS channels (in this case over the action protocol), but it also helps avoid race conditions that can occur from having two separate channels.</div>
<div><br></div><div>Option 2 - Two .action files and two action servers: Actionlib doesn't have support for multiple goal types by default, though you could build tools for handling this on top of the current protocol. The benefit here is that you have two clearly separated ROS interfaces, but the disadvantage is that you have to deal with a whole bunch of race conditions in how you want to process goals. You also have to handle the interaction between the two action servers.... like preempting a goal in one when a new one comes in over the wire for the other. Given the programming pain that comes along with this, we haven't actually used this option in practice... though it should be doable.</div>
<div><br></div><div>Option 3 - Conversion on the client side: Another option is to expose only one interface from the server, but to provide conversion utilities on the client side that make it easy to convert from a second type to the one the server requires. This assumes that there is a clear conversion procedure between the two desired goal types, but may work well in many cases.</div>
<div><br></div><div>Hope this helps,</div><div><br></div><div>Eitan<br><br><div class="gmail_quote">On Thu, Sep 16, 2010 at 10:22 AM, Axelrod, Benjamin <span dir="ltr"><<a href="mailto:baxelrod@irobot.com">baxelrod@irobot.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:12.0pt">What is the recommended way
to handle multiple goal types with actionlib? </span></p>
<p><span style="font-size:12.0pt"><span>1)<span style="font:7.0pt "Times New Roman""> </span></span></span><span style="font-size:12.0pt">Put flags in the .action file such that it can handle
multiple goal types? This means always have a single action file for each
server/client pair.</span></p>
<p><span style="font-size:12.0pt"><span>2)<span style="font:7.0pt "Times New Roman""> </span></span></span><span style="font-size:12.0pt">Make two different .action files:</span></p>
<p style="margin-left:1.0in"><span style="font-size:12.0pt"><span>a.<span style="font:7.0pt "Times New Roman"">
</span></span></span><span style="font-size:12.0pt">Can a single server/client
pair handle multiple .action files?</span></p>
<p style="margin-left:1.0in"><span style="font-size:12.0pt"><span>b.<span style="font:7.0pt "Times New Roman"">
</span></span></span><span style="font-size:12.0pt">Should you have 2
actionlib servers and 2 actionlib clients? And if so, how can they interact?</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">For example, suppose you have
a node which drives a simple differential drive robot base. You want this
server to take either a drive straight distance, or the number of degrees to
rotate in place. Both actions can’t be going at the same
time. A new goal of one type should preempt the other. And the goal
specification, feedback, and result are different enough that it might make a
single .action file rather awkward. </span></p>
<p class="MsoNormal"><span style="font-size:12.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">I could imagine a single .action
file such as:</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">float32 driveStraightDistance</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">float32 rotateDegrees</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">bool driveStraight
#true to drive straight, false to rotate</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">---</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">float32 metersTraveled</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">float32 degreesRotated</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">bool driveStraight
#true if this goal was for a drive straight command</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">---</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">float32 metersTraveled</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">float32 degreesRotated</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">bool driveStraight #true
if this goal was for a drive straight command</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">Of course there are some
redundant fields there. This isn’t my exact use case, but you get
the idea…</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">Thanks,</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">-Ben</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:12.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:12.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">--</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">Ben Axelrod</span><span style="font-size:12.0pt"></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">Research Scientist</span><span style="font-size:12.0pt"></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">iRobot Corporation</span><span style="font-size:12.0pt"></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">8 Crosby Drive, Mail Stop 8-1</span><span style="font-size:12.0pt"></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">Bedford, MA 01730</span><span style="font-size:12.0pt"></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">(781) 430-3315 (Tel)</span></p>
<p class="MsoNormal"><span style="font-size:12.0pt">(781) 960-2628 (Fax)</span><span style="font-size:12.0pt"></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt"><a href="mailto:ofitch@irobot.com" target="_blank"><span style="color:windowtext">baxelrod@irobot.com</span></a></span><span style="font-size:12.0pt"></span></p>
<p class="MsoNormal"> </p>
</div>
</div>
<br>_______________________________________________<br>
ros-users mailing list<br>
<a href="mailto:ros-users@code.ros.org">ros-users@code.ros.org</a><br>
<a href="https://code.ros.org/mailman/listinfo/ros-users" target="_blank">https://code.ros.org/mailman/listinfo/ros-users</a><br>
<br></blockquote></div><br></div>