<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Thanks Jeremy and Eitan! It was rather minor, but I thought I should
report it. Looks great now.<br>
<br>
--patrick<br>
<br>
On 2/11/2011 9:24 AM, Eitan Marder-Eppstein wrote:
<blockquote
cite="mid:AANLkTi=yYvWrwyXPMYCcUidXMxuLDoDOsNiF8Ktty6ek@mail.gmail.com"
type="cite">Ah yes, I was rushing through changing the tutorials and
just blew off the code-ref sections. Things should be fixed across all
the actionlib tutorials now... this wasn't the only one I screwed with.
<div><br>
</div>
<div>Sorry for any confusion this caused.</div>
<div><br>
</div>
<div>Hope all is well,</div>
<div><br>
</div>
<div>Eitan<br>
<br>
<div class="gmail_quote">On Fri, Feb 11, 2011 at 9:12 AM, Jeremy
Leibs <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:leibs@willowgarage.com">leibs@willowgarage.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">On Fri, Feb 11, 2011 at 7:17 AM, Patrick Goebel <<a
moz-do-not-send="true" href="mailto:patrick@pirobot.org">patrick@pirobot.org</a>>
wrote:<br>
> I noticed a small glitch on the actionlib tutorial page for
writing a<br>
> Python server:<br>
><br>
> <a moz-do-not-send="true"
href="http://www.ros.org/wiki/actionlib_tutorials/Tutorials/Writing%20a%20Simple%20Action%20Server%20using%20the%20Execute%20Callback%20%28Python%29"
target="_blank">http://www.ros.org/wiki/actionlib_tutorials/Tutorials/Writing%20a%20Simple%20Action%20Server%20using%20the%20Execute%20Callback%20%28Python%29</a><br>
><br>
> The code breakdown for lines 40-45 is interrupted with the error:<br>
><br>
> ERROR: unindent does not match any outer indentation level<br>
><br>
> I saw that the CodeRef for that block was for lines 40-42 so I
changed<br>
> it to 40-45 but that did not fix the error so at this point I need
to<br>
> punt. (The Python indentation looks fine to my eye but maybe
someone<br>
> else can catch it.)<br>
<br>
</div>
The issue is that line 40-42 were:<br>
<br>
break<br>
self._feedback.sequence.append(self._feedback.sequence[i] +<br>
self._feedback.sequence[i-1])<br>
# publish the feedback<br>
<br>
I'm guessing the python code parser being applied to the range of<br>
values still wants it to be a valid python block, which this isn't.<br>
<br>
Changing it to 41-43 fixed the problem. However, looking at all the<br>
other code blocks, many of them now have the off-by-one error.<br>
<br>
I looked through a change log, and it looks like Eitan added:<br>
<br>
self._as.start()<br>
<br>
To line 18 of the referenced code block, but didn't update any of the<br>
coderefs. Any CodeRef referencing a number greater than 18 will need<br>
to be incremented by 1. Also, I'm sure one of the sections referenced<br>
the interval including 18 and the doc probably needs to be changed to<br>
include calling self._as.start()<br>
<div>
<div class="h5"><br>
<br>
><br>
> --patrick<br>
><br>
> _______________________________________________<br>
> ros-users mailing list<br>
> <a moz-do-not-send="true" href="mailto:ros-users@code.ros.org">ros-users@code.ros.org</a><br>
> <a moz-do-not-send="true"
href="https://code.ros.org/mailman/listinfo/ros-users" target="_blank">https://code.ros.org/mailman/listinfo/ros-users</a><br>
><br>
_______________________________________________<br>
ros-users mailing list<br>
<a moz-do-not-send="true" href="mailto:ros-users@code.ros.org">ros-users@code.ros.org</a><br>
<a moz-do-not-send="true"
href="https://code.ros.org/mailman/listinfo/ros-users" target="_blank">https://code.ros.org/mailman/listinfo/ros-users</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
ros-users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:ros-users@code.ros.org">ros-users@code.ros.org</a>
<a class="moz-txt-link-freetext" href="https://code.ros.org/mailman/listinfo/ros-users">https://code.ros.org/mailman/listinfo/ros-users</a>
</pre>
</blockquote>
</body>
</html>