<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>-1</div><div><br></div><div>It is a little hard to understand this trade due to lack of info, but I will justify my answer:</div><div><br></div><div>- There is a major re-write of code (both core ROS and community provided code) that could take significant time and effort to perform. It would be useful if an estimate of this impact could be given (even a WAG). However, maybe I am wrong.</div><div><br></div><div>- There appear to be no crucial information included in the new DisparityImage to really justify the change and the effort above. At least there is no clear, compelling argument in the REP. </div><div><br></div><div>- I dislike the justification being because one vendor has set a precedent. What happens when the kinect 2 comes out with a different format, will we adapt that format as the next default? What happens if OpenNI goes away and Nintendo (just picked someone at random) invents a really cool depth sensor that works different? I think our depth image should be based on what is right for us and not what one vender provides today. Just remember, the Kinect is only a little over one year old. What will next year this time bring?</div><div><br></div><div>I did like the idea of uint16 taking less bandwidth and potentially running on simpler hardware (ARM, netbook, etc). However, I find none of the arguments compelling.</div><div><br></div><div>So you are proposing:</div><div>DisparityImage of type uint16</div><div>- focal length, baseline, principal point</div><div>- valid_window (seems unnecessary)</div><div>- min/max disparity</div><div>- delta_d</div><div><br></div><div>I assume we would get rid of the need for CameraInfo when used with DisparityImage message if this is done.</div><div><br></div><div>What is the impact of instead publishing a separate topic to fill in these couple of missing metadata pieces? This changes things from (Image, CameraInfo) pair to (Image, CameraInfo, ??) triplet … not sure that is super great, but the impact may be much less. </div><div><br></div><div>Also, not to be too critical, but I had a problem following the logic of this entire REP. I am sure it makes complete sense to the author, however I found the logic to jump around.</div><div><br></div><div>This is an interesting suggestion, lets just make sure it is the right one for ROS ... thanks!</div><div><br></div><div>Kevin</div><div><br></div><br><div><div>On Dec 6, 2011, at 5:51 PM, Patrick Mihelich wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Hi all,<br><br>Attached is a draft REP defining a representation for
depth images in ROS. This standardizes the format used by the ROS OpenNI
driver and associated processing nodelets, and should be useful to
other producers/consumers of depth data.<br>
<br>You can also view it in HTML at <a href="http://people.willowgarage.com/mihelich/rep-depth-image.html" target="_blank">http://people.willowgarage.com/mihelich/rep-depth-image.html</a>.<br><br>If this interests you, please state your vote (see <a href="http://ros.org/reps/rep-0010.html" target="_blank">REP 10 - Voting Guidelines</a>) as well as any comments and concerns.<br>
<br>We seem to be having archival issues, so (light) early feedback for the ros-sig-perpip list is reproduced below.<br><br>Cheers,<br><font color="#888888">Patrick</font><br><br><div class="gmail_quote"><span style="font-size: large; font-weight: bold;">Forwarded conversation</span><br>
Subject: <b class="gmail_sendername">Depth image REP</b><br>------------------------<br><span class="undefined"></span><br><span class="undefined"><font color="#000000">From: <b class="undefined">Ethan Rublee</b> <span dir="ltr"><<a href="mailto:erublee@willowgarage.com">erublee@willowgarage.com</a>></span><br>
Date: Fri, Dec 2, 2011 at 3:56 PM<br>To: Patrick Mihelich <<a href="mailto:mihelich@willowgarage.com">mihelich@willowgarage.com</a>><br>Cc: <a href="mailto:ros-sig-perpip@code.ros.org">ros-sig-perpip@code.ros.org</a><br>
</font><br></span><br>+1<br>
<br>----------<br><span class="undefined"><font color="#000000">From: <b class="undefined">Vincent Rabaud</b> <span dir="ltr"><<a href="mailto:vrabaud@willowgarage.com">vrabaud@willowgarage.com</a>></span><br>Date: Fri, Dec 2, 2011 at 4:13 PM<br>
To: Ethan Rublee <<a href="mailto:erublee@willowgarage.com">erublee@willowgarage.com</a>><br>Cc: Patrick Mihelich <<a href="mailto:mihelich@willowgarage.com">mihelich@willowgarage.com</a>>, <a href="mailto:ros-sig-perpip@code.ros.org">ros-sig-perpip@code.ros.org</a><br>
</font><br></span><br>+0, it looks good but I don't know much about the previous messages. The deprecation of the DisparityImage will happen through the tic-toc I guess.<div><div></div></div><br>----------<br><span class="undefined"><font color="#000000">From: <b class="undefined">Brian Gerkey</b> <span dir="ltr"><<a href="mailto:gerkey@willowgarage.com">gerkey@willowgarage.com</a>></span><br>
Date: Fri, Dec 2, 2011 at 5:47 PM<br>To: Patrick Mihelich <<a href="mailto:mihelich@willowgarage.com">mihelich@willowgarage.com</a>><br>Cc: <a href="mailto:ros-sig-perpip@code.ros.org">ros-sig-perpip@code.ros.org</a><br>
</font><br></span><br>+0.<br>
<br>
I'm not a user of this part of the system, but find the REP to be<br>
well-reasoned and convincing.<br>
<font color="#888888"><br>
brian.<br>
</font><div><div></div></div><br></div><br>
<span><rep-depth-image.txt></span>_______________________________________________<br>ros-users mailing list<br><a href="mailto:ros-users@code.ros.org">ros-users@code.ros.org</a><br>https://code.ros.org/mailman/listinfo/ros-users<br></blockquote></div><br></body></html>