[ros-users] call for testing: camera1394 in C-turtle

Patrick Beeson beeson.p at gmail.com
Wed Jun 16 18:57:35 UTC 2010


> Would you send me your patch, please?

Jack,  Looking carefully at Coriander, if absolute_capable is TRUE then 
it will DISPLAY absolute values (like real valued shutter speed instead 
of integers than mean little).  But it will only allow the user to EDIT 
(thus calling set_absolute_value) is abs_control is also TRUE.  On the 
XCD cameras, abs_control is FALSE.

A very simple fix makes this work correctly.


Index: src/nodes/features.cpp
===================================================================
--- src/nodes/features.cpp	(revision 30293)
+++ src/nodes/features.cpp	(working copy)
@@ -284,7 +284,7 @@
          }

        // TODO: break this into some internal methods
-      if (finfo->absolute_capable)      // supports float value?
+      if (finfo->absolute_capable && finfo->abs_control) // supports 
float value?
          {
            float fmin, fmax;
            if (DC1394_SUCCESS ==
===================================================================



More information about the ros-users mailing list