Re: [ros-users] stereo proc

Top Page
Attachments:
Message as email
+ (text/plain)
+ stereo_camera_model.diff (text/x-patch)
Delete this message
>>>> to="parameter_descriptions" /> > >>>> > >>>>                    >>>> to="parameter_updates" /-->%0A>%20>>>>%0A>%20>>>>%20%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%20%C2%A0%20</node>%0A>%20>>>>%0A>%20>>>>%0A>%20>>>>%0A>%20>>>>%0A>%20>>>>%0A>%20>>>>%20It%20crashes%20and%20returns%20the%20below%20message%20when%20I%20attempt%20to%20view%20the%20images%0A>%20>>>>%20by%20stereo_view%0A>%20>>>>%0A>%20>>>>%0A>%20>>>>%0A>%20>>>>%20process%5Bstereo/stereo_image_proc-1%5D:%20started%20with%20pid%20%5B6045%5D%0A>%20>>>>%0A>%20>>>>%20stereo_image_proc:%0A>%20>>>>%20/tmp/buildd/ros-diamondback-vision-opencv-1.4.0/debian/ros-diamondback-vision-opencv/opt/ros/diamondback/stacks/vision_opencv/image_geometry/include/image_geometry/pinhole_camera_model.h:288:%0A>%20>>>>%20std::string%20image_geometry::PinholeCameraModel::tfFrame()%20const:%20Assertion%0A>%20>>>>%20%60initialized()'%20failed.%0A>%20>>>>%0A>%20>>>>%20%5Bstereo/stereo_image_proc-1%5D%20process%20has%20died%20%5Bpid%206045,%20exit%20code%20-6%5D.%0A>%20>>>>%0A>%20>>>>%20log%20files:%0A>%20>>>>%20/home/reza/.ros/log/967559ac-38dd-11e0-bc77-00808288094c/stereo/stereo_image_proc-1*.log%0A>%20>>>>%0A>%20>>>>%20all%20processes%20on%20machine%20have%20died,%20roslaunch%20will%20exit%0A>%20>>>>%0A>%20>>>>%20shutting%20down%20processing%20monitor...%0A>%20>>>>%0A>%20>>>>%20...%20shutting%20down%20processing%20monitor%20complete%0A>%20>>>>%0A>%20>>>>%20done%0A>%20>>>>%0A>%20>>>>%0A>%20>>>>%0A>%20>>>>%20Reza,%0A>%20>>>>%0A>%20>>>>%0A>%20>>>>%0A>%20>>>>%20_______________________________________________%0A>%20>>>>%20ros-users%20mailing%20list%0A>%20>>>>%20ros-users@code.ros.org%0A>%20>>>>%20https://code.ros.org/mailman/listinfo/ros-users%0A>%20>>>>%0A>%20>>>>%0A>%20>>>%0A>%20>>>%0A>%20>>>%0A>%20>>>%20--%0A>%20>>>%20Matei%20Ciocarlie%0A>%20>>>%20Research%20Scientist%0A>%20>>>%20Willow%20Garage%20Inc.%0A>%20>>>%20650-475-9780%0A>%20>>>%20_______________________________________________%0A>%20>>>%20ros-users%20mailing%20list%0A>%20>>>%20ros-users@code.ros.org%0A>%20>>>%20https://code.ros.org/mailman/listinfo/ros-users%0A>%20>>>%0A>%20>>%20_______________________________________________%0A>%20>>%20ros-users%20mailing%20list%0A>%20>>%20ros-users@code.ros.org%0A>%20>>%20https://code.ros.org/mailman/listinfo/ros-users%0A>%20>>%0A>%20>%0A>%20>%0A>%20>%0A>%20>%20--%0A>%20>%20Matei%20Ciocarlie%0A>%20>%20Research%20Scientist%0A>%20>%20Willow%20Garage%20Inc.%0A>%20>%20650-475-9780%0A>%20>%20_______________________________________________%0A>%20>%20ros-users%20mailing%20list%0A>%20>%20ros-users@code.ros.org%0A>%20>%20https://code.ros.org/mailman/listinfo/ros-users%0A>%20>%0A>%20">Reply to this message
Author: User discussions
Date:  
To: User discussions
Subject: Re: [ros-users] stereo proc
Matei,

Here it is.

Thanks,
Anton

On Tue, Feb 15, 2011 at 2:33 PM, Matei Ciocarlie <> wrote:
> Anton - thanks a lot for the info. Could you please attach a diff?
>
> Matei
>
> On Tue, Feb 15, 2011 at 1:28 PM, Antons Rebguns <> wrote:
>> Matei,
>>
>> I am having the same problem trying to make videre_stereo_cam package
>> working with Diamondback. I think I found the culprit in
>> stereo_camera_model.cpp in from_camera_info method. The first time you
>> run the camera fromCameraInfo(left, right) left_.fromCameraInfo(left)
>> returns true and the second part of the or statement is short
>> circuited so right_ is never initialized. If you split these into two
>> lines everything works as expected.
>>
>> Anton
>>
>> On Tue, Feb 15, 2011 at 2:10 PM, Matei Ciocarlie <> wrote:
>>> Hi Reza,
>>>
>>> We're seeing this as well, ticketed here:
>>>
>>> https://code.ros.org/trac/wg-ros-pkg/ticket/5019
>>>
>>> We don't have a solution yet, but as a temporary stopgap reverting the
>>> two stacks mentioned in the ticket will fix it. You will need to
>>> overlay vision_opencv_1.3.7 and image_pipeline_1.3.0 over your
>>> diamondback install.
>>> Matei
>>>
>>> On Tue, Feb 15, 2011 at 1:00 AM, Asghari Oskoei, Mohammadreza
>>> <> wrote:
>>>>
>>>>
>>>> Hi,
>>>>
>>>> I run stereo_image_proc  by
>>>>
>>>>
>>>>
>>>>                  <node ns="stereo" pkg="stereo_image_proc"
>>>> type="stereo_image_proc" respawn="false" name="stereo_image_proc"
>>>> args="_approximate_sync:=True">
>>>>
>>>>                    <!--remap from="stereo_image_proc/parameter_descriptions"
>>>> to="parameter_descriptions" />
>>>>
>>>>                    <remap from="stereo_image_proc/parameter_updates"
>>>> to="parameter_updates" /-->
>>>>
>>>>                  </node>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> It crashes and returns the below message when I attempt to view the images
>>>> by stereo_view
>>>>
>>>>
>>>>
>>>> process[stereo/stereo_image_proc-1]: started with pid [6045]
>>>>
>>>> stereo_image_proc:
>>>> /tmp/buildd/ros-diamondback-vision-opencv-1.4.0/debian/ros-diamondback-vision-opencv/opt/ros/diamondback/stacks/vision_opencv/image_geometry/include/image_geometry/pinhole_camera_model.h:288:
>>>> std::string image_geometry::PinholeCameraModel::tfFrame() const: Assertion
>>>> `initialized()' failed.
>>>>
>>>> [stereo/stereo_image_proc-1] process has died [pid 6045, exit code -6].
>>>>
>>>> log files:
>>>> /home/reza/.ros/log/967559ac-38dd-11e0-bc77-00808288094c/stereo/stereo_image_proc-1*.log
>>>>
>>>> all processes on machine have died, roslaunch will exit
>>>>
>>>> shutting down processing monitor...
>>>>
>>>> ... shutting down processing monitor complete
>>>>
>>>> done
>>>>
>>>>
>>>>
>>>> Reza,
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> ros-users mailing list
>>>>
>>>> https://code.ros.org/mailman/listinfo/ros-users
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Matei Ciocarlie
>>> Research Scientist
>>> Willow Garage Inc.
>>> 650-475-9780
>>> _______________________________________________
>>> ros-users mailing list
>>>
>>> https://code.ros.org/mailman/listinfo/ros-users
>>>
>> _______________________________________________
>> ros-users mailing list
>>
>> https://code.ros.org/mailman/listinfo/ros-users
>>
>
>
>
> --
> Matei Ciocarlie
> Research Scientist
> Willow Garage Inc.
> 650-475-9780
> _______________________________________________
> ros-users mailing list
>
> https://code.ros.org/mailman/listinfo/ros-users
>

--- stereo_camera_model_old.cpp    2011-02-10 19:02:21.000000000 -0700
+++ stereo_camera_model.cpp    2011-02-15 14:36:16.217075642 -0700
@@ -20,7 +20,9 @@ StereoCameraModel::StereoCameraModel(con
 bool StereoCameraModel::fromCameraInfo(const sensor_msgs::CameraInfo& left,
                                        const sensor_msgs::CameraInfo& right)
 {
-  bool changed = left_.fromCameraInfo(left) || right_.fromCameraInfo(right);
+  bool changed_left = left_.fromCameraInfo(left);
+  bool changed_right = right_.fromCameraInfo(right);
+  bool changed = changed_left || changed_right;


// Note: don't require identical time stamps to allow imperfectly synced stereo.
assert( left_.tfFrame() == right_.tfFrame() );