Re: [ros-users] Announcing rosserial

Ok, I just ran through this with Adam. It's now time to open an API review
on rosserial: http://www.ros.org/wiki/rosserial/Reviews/2011-08-04 API
Review_API_Review (I'll be sending out an official announcement shortly)

As to your patches:

1) Allow custom baudrates -- I've added this to our API review discussion.
The issue becomes the PC-side, in that we don't want to have *any*
configuration data (and that includes baud rate) stored on the PC.

2) Simplify Subscriber/Publisher constructors -- we actually don't want to
do this. While we currently don't make use of the message pointer, there is
some automatic packet resend work in development that would make use of the
message pointer. If you still feel this is necessary, please bring it up in
the API review.

3) Signed char* -- good catch, I created a ticket (#20)

I'm posting comments to most of your tickets, Adam is taking a look at #18
(CMake issues).

-Fergs




Attached are a couple of patches I'd ask for inclusion into rosserial:
>
> - allow custom baudrates
> - simplify Subscriber/Publisher constructors
> - make strings signed char*, instead of unsigned char*
>
> cheers
> Dariush
> --
> Institut für Technische Informatik / Universität zu Lübeck
> http://www.iti.uni-luebeck.de/**index.php?id=forouher0<http://www.iti.uni-luebeck.de/index.php?id=forouher0>
>
> _______________________________________________
> ros-users mailing list
> ros-users@code.ros.org
> https://code.ros.org/mailman/listinfo/ros-users
>
>