Re: [ros-users] patch + packages for ccny_vision on natty

Looking at the SED code
$ roscd artoolkit
$ sed -i 's,#include <linux/videodev.h>,#include <libv4l1-videodev.h>,g' ./build/artoolkit/include/AR/sys/videoLinuxV4L.h
$ sed -i 's,#include <linux/videodev.h>,#include <libv4l1-videodev.h>,g' ./build/artoolkit/lib/SRC/VideoLinuxV4L/video.c

It is clear that this patch will break previous version.

You need something like ifdefs

#ifdef LIBV4L1
#include <libv4l1-videodev.h>
#else
#include <linux/videodev.h>
#endif


I built the previous patched artoolkit.
You need to be added to the thirdparty group on code.ros.org
https://code.ros.org/svn/release/download/thirdparty


On Fri, 2011-10-07 at 17:47 -0400, Carlos J. wrote:
> Piyush,
>
> Thanks for patching ARToolKit, However we have a concern: will this
> modifications you've made to the v4l header affect other Ubuntu
> distributions prior to Natty? In other words, before we make the patch
> official, we must ensure that the patch will not affect other users
> who run older Ubuntu distros.
>
> If that's the case, we will ask Ken from WG to upload the patched
> ARToolKit to the download server at code.ros.org
>
> Carlos
>
> On Tue, Oct 4, 2011 at 1:26 PM, Piyush Khandelwal <piyushk@cs.utexas.edu> wrote:
> > Hi,
> >
> > Currently ccny_vision has no packages for natty as it does not build
> > without a patch. See: http://robotics.ccny.cuny.edu/trac/ticket/55
> > Instructions for manually patching are available here:
> > http://www.ros.org/wiki/artoolkit
> >
> > I have a patch available at
> > http://www.cs.utexas.edu/~piyushk/artoolkit-patch-natty.txt which
> > automates the procedure above. i.e I can run this on any of my
> > machines using the following commands:
> >
> > git clone http://robotics.ccny.cuny.edu/git/ccny-ros-pkg/ccny_vision.git
> > cd ccny_vision
> > wget http://www.cs.utexas.edu/~piyushk/artoolkit-patch-natty.txt
> > git apply artoolkit-patch-natty.txt
> > rosmake ccny_vision --rosdep-install
> >
> > Note: The tar downloaded will be
> > http://www.cs.utexas.edu/~piyushk/ARToolKit-Natty.tar.gz. This has
> > been patched.
> >
> > Is anybody from WG or CCNY interested in a more permanent fix to the
> > problem, i.e. releasing packages for easier use. I am unfamiliar with
> > the build process for releasing debs, so I am not sure how much work
> > this entails.
> >
> > Thanks!
> > Piyush
> > _______________________________________________
> > ros-users mailing list
> > ros-users@code.ros.org
> > https://code.ros.org/mailman/listinfo/ros-users
> >
> _______________________________________________
> ros-users mailing list
> ros-users@code.ros.org
> https://code.ros.org/mailman/listinfo/ros-users

--
Bill Morris <bill@iheartengineering.com>
I Heart Engineering
http://www.iheartengineering.com
<3