Hi Radu,
Ok I created a ticket. But it may be a larger issue than just consistency in
SACSegmentation::setEpsAngle(). Also, you don't necessarily want to break
existing code without warning. Maybe you should decide on a unit system and
put a clear indication in the documentation that as of version XXX all units
will be standardized?
-Jared
Quoting Radu Bogdan Rusu <
rusu@willowgarage.com>:
> Hi Jared,
>
> oops. Can you please send me a patch (ticket works too)?
>
> Thanks,
> Radu.
>
> On 08/10/2010 02:05 PM, Jared Marshall Glover wrote:
>> There seems to be an inconsistency in PCL (at least in cturtle...I haven't
>> checked latest), in that some methods take angles in radians and some in
>> degrees. For example, SACSegmentation::setEpsAngle() accepts degrees for
>> SACMODEL_ORIENTED_PLANE, but radians for SACMODEL_ORIENTED_LINE.
>> Perhaps there
>> should be a single convention throughout PCL to avoid confusion?
>> It's already
>> caused some headaches around here =)
>>
>> -Jared
>>
>>
>> _______________________________________________
>> ros-users mailing list
>> ros-users@code.ros.org
>> https://code.ros.org/mailman/listinfo/ros-users
>
> --
> | Radu Bogdan Rusu | http://rbrusu.com/
>
(text/plain)