[quote="gbiggs, post:2, topic:6656"]
Just plain making a package work in ROS2 is useful, but **you should do more than just port**. You should take advantage of as much of the new capabilities allowed by ROS2 as possible. This means things like restructuring the design of nodes to be composable, taking advantage of QoS and deciding the best default QoS for each topic, using local parameters, and using read only parameters where it makes sense (when they become available). **Once code is available working in ROS2 I think it is less likely that such restructuring will be done**, so doing it as part of the porting process is valuable.
[/quote]
Yes, this.
This is so important, it cannot be stated often enough.
As nice as plain ports are, they will never be what the pkgs could be if they were only conceptually ported instead of `s|#include <ros/ros.h>|#include <ros2/ros2.h>|g` (I know that doesn't work that way .. if only), and when there is a plain port, there will be much less of an incentive to do anything about the ported pkg as it's there and it works .. well enough.
---
[Visit Topic](
https://discourse.ros.org/t/introduction-of-persistent-systems-to-ros2-initiative/6656/3) or reply to this email to respond.
If you do not want to receive messages from ros-users please use the unsubscribe link below. If you use the one above, you will stop all of ros-users from receiving updates.
______________________________________________________________________________
ros-users mailing list
ros-users@lists.ros.org
http://lists.ros.org/mailman/listinfo/ros-users
Unsubscribe: <
http://lists.ros.org/mailman//options/ros-users>
(text/plain)